Add Any type and remove gogo protobuf from interfaces#31
Merged
kzys merged 1 commit intocontainerd:mainfrom Mar 21, 2022
Merged
Add Any type and remove gogo protobuf from interfaces#31kzys merged 1 commit intocontainerd:mainfrom
kzys merged 1 commit intocontainerd:mainfrom
Conversation
Add a new Any type which can be used with gogo or google protobuf libraries. Support marshaling and unmarshaling with either library. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 67.36% 59.63% -7.74%
==========================================
Files 1 1
Lines 95 109 +14
==========================================
+ Hits 64 65 +1
- Misses 23 37 +14
+ Partials 8 7 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mxpv
approved these changes
Mar 20, 2022
kzys
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new Any type which can be used with gogo or google protobuf libraries. Support marshaling and unmarshaling with either library.
This is needed to help us move away from gogo protobuf and to break out reliance on external types in our interface (
*types.Any->typeurl.Any).With this change, will probably make sense to tag as v2.0 and tag the current version as v1.0.3