return ErrClosed if read: connection reset by peer#53
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Oct 23, 2019
Merged
Conversation
When call server.Close(), server will close all listener and notify flighting-connection to shutdown. Connections are closed asynchronously. In TestClientEOF, client can send request into closing-connection. But the read for reply will return error if the closing-connection is shutdown. In this case, we should filter error for client side about `read: connection reset by peer`. Signed-off-by: Wei Fu <[email protected]>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When call server.Close(), server will close all listener and notify
flighting-connection to shutdown. Connections are closed asynchronously.
In TestClientEOF, client can send request into closing-connection. But
the read for reply will return error if the closing-connection is
shutdown.
In this case, we should filter error for client side about
read: connection reset by peer.Signed-off-by: Wei Fu [email protected]