Fix grammar in comment for UserOnCloseWait.#153
Merged
fuweid merged 1 commit intocontainerd:mainfrom Aug 7, 2023
Merged
Conversation
klihub
changed the title
klihub
force-pushed
the
fixes/UserOnCloseWait-comment
branch
from
76f0c44 to
fd0dff6
Compare
estesp
approved these changes
Jul 27, 2023
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
good catch; your edit is correct
Member
Author
|
And I think the CI errors we see here are fixed by #150. Once we get that merged, I can rebase this and it should make those errors go away. |
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/UserOnCloseWait-comment
branch
from
fd0dff6 to
8ca4110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at
client.go:UserOnCloseWait()based on a review comment for #150, I spotted something that looks like grammar errors in a docstring comment which then ends up being part of the package documentation here.Can some of the native speakers double-check that I didn't simply trade a grammar error for another one ?