Implement support for unary interceptor chaining.#152
Merged
fuweid merged 2 commits intocontainerd:mainfrom Sep 6, 2023
Merged
Implement support for unary interceptor chaining.#152fuweid merged 2 commits intocontainerd:mainfrom
fuweid merged 2 commits intocontainerd:mainfrom
Conversation
klihub
force-pushed
the
devel/unary-interceptor-chaining
branch
from
acdf1cf to
342716c
Compare
klihub
force-pushed
the
devel/unary-interceptor-chaining
branch
2 times, most recently
from
ac67b22 to
db08a00
Compare
fuweid
reviewed
Aug 7, 2023
Add a WithChainUnaryClientInterceptor client option to allow using more that one client call interceptor which will then get chained and invoked in the order given. This should allow us to implement opentelemetry instrumentation as interceptors while allowing users to keep intercepting their client calls for other reasons at the same time. Signed-off-by: Krisztian Litkey <[email protected]>
Add a WithChainUnaryServerInterceptor server option to allow using more that one server side interceptor which will then get chained and invoked in the order given. This should allow us to implement opentelemetry instrumentation as interceptors while allowing users to keep intercepting their server side calls for other reasons at the same time. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/unary-interceptor-chaining
branch
from
db08a00 to
40f227d
Compare
dmcgowan
approved these changes
Sep 5, 2023
Member
|
This looks ready to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
WithChainUnaryClientInterceptorandWithChainUnaryServerInterceptorclient and server options. These allow registering more than one client and server side interceptor which then get chained and invoked in the order of registration.This should allow us to implement opentelemetry instrumentation for unary calls as unary interceptors while allowing users to keep intercepting their client and server side ttrpc calls for other reasons at the same time. These commits were split out from #145.