server_test: wait for OnClose in TestClientEOF.#150
Merged
fuweid merged 1 commit intocontainerd:mainfrom Jul 28, 2023
Merged
Conversation
estesp
approved these changes
Jul 24, 2023
Iceber
reviewed
Jul 25, 2023
klihub
force-pushed
the
fixes/server-test/TestClientEOF
branch
4 times, most recently
from
7850c9d to
519cb47
Compare
In the test for client Call failing with ErrClosed on a closed server, wait for the client's OnClose handler to get triggered to make sure closing the socket had properly been administered on the client's side. Otherwise trying a new Call() might fail with some other error than ErrClosed, for instance ENOTCONN. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/server-test/TestClientEOF
branch
from
519cb47 to
e0cd801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test for client
Call()failing withErrClosedon a closed server, wait for the client'sOnClose()handler to get triggered to make sure closing the socket had properly been administered on the client's side. Otherwise trying a newCall()might fail with some other error thanErrClosed, for instanceENOTCONN.This commit was split out from #145 as a PR of its own.