Unwrap IO errors in server connection error handling #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
fix-error-check-in-server
branch
2 times, most recently
from
3099ec0 to
40e8044
Compare
austinvazquez
changed the title
austinvazquez
force-pushed
the
fix-error-check-in-server
branch
from
40e8044 to
b320c3e
Compare
Member
Author
Unwrap io.EOF and io.ErrUnexpectedEOF in the case of read message error which would lead to leaked server connections. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
fix-error-check-in-server
branch
from
b320c3e to
9599fad
Compare
austinvazquez
changed the title
austinvazquez
commented
May 2, 2023
dmcgowan
approved these changes
May 2, 2023
Iceber
approved these changes
May 5, 2023
cpuguy83
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
Unwrap
io.EOFandio.ErrUnexpectedEOFin server connection receive error handling. When read message errors occurs, the error is wrapped to be more distinguishable from read message header errors; however, without unwrapping the errors here the result would be leaked server connections for connections where the client is now gone.Signed-of-by: Austin Vazquez [email protected]