Rework deadline assertion logging to be more clear#132
Merged
estesp merged 1 commit intocontainerd:mainfrom Mar 8, 2023
Merged
Rework deadline assertion logging to be more clear#132estesp merged 1 commit intocontainerd:mainfrom
estesp merged 1 commit intocontainerd:mainfrom
Conversation
Make `TestServerRequestTimeout` deadline assertion log print expected and actual values in the same format for more clear troubleshooting. Signed-off-by: Austin Vazquez <[email protected]>
Member
Author
swagatbora90
approved these changes
Mar 3, 2023
cpuguy83
approved these changes
Mar 7, 2023
dmcgowan
approved these changes
Mar 8, 2023
Member
|
With the fixes now merged, this should get a rebase so it can pass CI |
estesp
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
TestServerRequestTimeoutdeadline assertion log print expectedand actual values in the same format for more clear troubleshooting.
For troubleshooting #131
Signed-off-by: Austin Vazquez [email protected]