Merged
Conversation
austinvazquez
force-pushed
the
fix-server-shutdown
branch
10 times, most recently
from
fc0e242 to
9925d37
Compare
Member
Author
austinvazquez
force-pushed
the
fix-server-shutdown
branch
3 times, most recently
from
6006966 to
e5894c3
Compare
austinvazquez
force-pushed
the
fix-server-shutdown
branch
from
e5894c3 to
dcee46b
Compare
Simplify close idle connections logic in server shutdown to be more intuitive. Modify add connection logic to check if server has been shutdown before adding any new connections. Modify test to make all calls before server shutdown. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
fix-server-shutdown
branch
from
dcee46b to
19445fd
Compare
This was referenced Feb 27, 2023
kzys
approved these changes
Mar 7, 2023
Member
cpuguy83
approved these changes
Mar 7, 2023
dmcgowan
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129
Simplify close idle connections logic in server shutdown to be more
intuitive. Modify add connection logic to check if server has been
shutdown before adding any new connections. Modify test to make all
calls before server shutdown.
Signed-off-by: Austin Vazquez [email protected]