Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 72.80% 63.67% -9.13%
==========================================
Files 11 11
Lines 728 1049 +321
==========================================
+ Hits 530 668 +138
- Misses 156 336 +180
- Partials 42 45 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We have lost Codecov since containerd#101. While the main containerd repository doesn't have that, ttrpc could have Codecov without much complications. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
The inaccurate comment kind of highlights why we got rid of it in the first place. Are we using it wrong? If it just consistently adds meaningless comments with numbers that don't indicate anything, we shouldn't reenable. If we just need to fix some configuration and it will actually work, then sure. |
|
We haven't sent information to Codecov for roughly a month. Having outdated information on their end (hence reporting the drop) makes some sense. I'd like to give it a try. If it still fluctuates for a few months, we can remove the action. |
3 participants
We have lost Codecov since #101. While the main containerd repository
doesn't have that, ttrpc could have Codecov without much complications.
Signed-off-by: Kazuyoshi Kato [email protected]