Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containerd/ttrpc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.5
Choose a base ref
...
head repository: containerd/ttrpc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.7
Choose a head ref
  • 11 commits
  • 7 files changed
  • 7 contributors

Commits on Aug 19, 2024

  1. server_test: fix error message in TestOversizeCall.

    Fix copy-pasted error message in unit test.
    
    Signed-off-by: Krisztian Litkey <[email protected]>
    klihub committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    84e1784 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    3f02183 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. channel: reject oversized messages on the sender side.

    Reject oversized messages on the sender side, keeping the
    receiver side rejection intact. This should provide minimal
    low-level plumbing for clients to attempt application level
    corrective actions on the requestor side, if the high-level
    protocol is designed with this in mind.
    
    Co-authored-by: Alessio Cantillo <[email protected]>
    Co-authored-by: Qian Zhang <[email protected]>
    Signed-off-by: Krisztian Litkey <[email protected]>
    3 people committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    de273bf View commit details
    Browse the repository at this point in the history
  2. channel_test: update oversize message test.

    Co-authored-by: Alessio Cantillo <[email protected]>
    Co-authored-by: Qian Zhang <[email protected]>
    Signed-off-by: Krisztian Litkey <[email protected]>
    3 people committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d8c00df View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. channel: allow discovery of overflown message size.

    Use a dedicated, grpc Status-compatible error to wrap the
    unique grpc status code, the size of the rejected message
    and the maximum allowed size when a message is rejected
    due to size limitations by the sending side.
    
    Signed-off-by: Krisztian Litkey <[email protected]>
    klihub committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b5cd6e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. server_test: add Serve()/Shutdown() race test.

    Signed-off-by: Krisztian Litkey <[email protected]>
    klihub committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ed6c3ba View commit details
    Browse the repository at this point in the history
  2. server: fix Serve() vs. immediate Shutdown() race.

    Fix a race where an asynchronous server.Serve() invoked in a
    a goroutine races with an almost immediate server.Shutdown().
    If Shutdown() finishes its locked closing of listeners before
    Serve() gets around to add the new one, Serve will sit stuck
    forever in l.Accept(), unless the caller closes the listener
    in addition to Shutdown().
    
    This is probably almost impossible to trigger in real life,
    but some of the unit tests, which run the server and client
    in the same process, occasionally do trigger this. Then, if
    the test tries to verify a final ErrServerClosed error from
    Serve() after Shutdown() it gets stuck forever.
    
    Signed-off-by: Krisztian Litkey <[email protected]>
    klihub committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c4d96d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge pull request #171 from klihub/devel/sender-side-oversize-rejection

    channel: reject oversized messages on the sender side(, too).
    dmcgowan authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bcc40a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge pull request #175 from klihub/fixes/serve-listen-shutdown-race

    server: fix a Serve() vs. (immediate) Shutdown() race
    AkihiroSuda authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b71d9de View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2024

  1. Add MD.Clone

    Signed-off-by: Jin Dong <[email protected]>
    djdongjin committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    430f734 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2024

  1. Merge pull request #177 from djdongjin/metadata-clone

    Add MD.Clone function
    fuweid authored Dec 28, 2024
    Configuration menu
    Copy the full SHA
    3b8c8b7 View commit details
    Browse the repository at this point in the history
Loading