Fix handling of empty payloads

mxpv · mxpv · commit dea99e9d052d · 2024-02-02T12:10:01.000-08:00
Signed-off-by: Maksym Pavlenko &lt;pavlenko.maksym@gmail.com&gt;
diff --git a/integration/streaming_test.go b/integration/streaming_test.go
@@ -420,9 +420,6 @@ func emptyPayloadStream(ctx context.Context, client streaming.TTRPCStreamingClie
 			}
 		}
 
-		if err := stream.CloseSend(); err != nil {
-			t.Fatal(err)
-		}
 		if _, err := stream.Recv(); err != io.EOF {
 			t.Fatalf("Expected io.EOF, got %v", err)
 		}
diff --git a/services.go b/services.go
@@ -140,7 +140,7 @@ func (s *serviceSet) handle(ctx context.Context, req *Request, respond func(*sta
 			respond(st, p, stream.StreamingServer, true)
 		}()
 
-		if req.Payload != nil {
+		if req.Payload != nil || !info.StreamingClient {
 			unmarshal := func(obj interface{}) error {
 				return protoUnmarshal(req.Payload, obj)
 			}

Original file line number	Diff line number	Diff line change
`@@ -420,9 +420,6 @@ func emptyPayloadStream(ctx context.Context, client streaming.TTRPCStreamingClie`
`420`	`420`	`}`
`421`	`421`	`}`
`422`	`422`
`423`		`- if err := stream.CloseSend(); err != nil {`
`424`		`- t.Fatal(err)`
`425`		`- }`
`426`	`423`	`if _, err := stream.Recv(); err != io.EOF {`
`427`	`424`	`t.Fatalf("Expected io.EOF, got %v", err)`
`428`	`425`	`}`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ func (s serviceSet) handle(ctx context.Context, req Request, respond func(*sta`
`140`	`140`	`respond(st, p, stream.StreamingServer, true)`
`141`	`141`	`}()`
`142`	`142`
`143`		`- if req.Payload != nil {`
	`143`	`+ if req.Payload != nil \|\| !info.StreamingClient {`
`144`	`144`	`unmarshal := func(obj interface{}) error {`
`145`	`145`	`return protoUnmarshal(req.Payload, obj)`
`146`	`146`	`}`