ctr-remote: improve sortEntries performance from O(k·n) to O(n)+O(k)#2153
Merged
ktock merged 1 commit intocontainerd:mainfrom Oct 29, 2025
Merged
ctr-remote: improve sortEntries performance from O(k·n) to O(n)+O(k)#2153ktock merged 1 commit intocontainerd:mainfrom
ktock merged 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: abushwang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Testing revealed that
sortEntriesexecution time increases significantly with largerprioritizedinput lists. The original implementation callsin.remove(name)for each prioritized entry, which rebuilds the entire stream (O(n) operation). When processing k prioritized files, this results in O(k·n) time complexity, causing severe performance degradation with large priority lists.Solution
Instead of removing entries one by one, the optimized version:
addRecto collect prioritized entries and mark them in apickedsetdumpExceptto exclude marked entries