Fix file exists error when restoring remote snapshot after unexpected…#2091
Merged
ktock merged 1 commit intocontainerd:mainfrom Jul 24, 2025
Merged
Fix file exists error when restoring remote snapshot after unexpected…#2091ktock merged 1 commit intocontainerd:mainfrom
ktock merged 1 commit intocontainerd:mainfrom
Conversation
… restart Signed-off-by: abushwang <[email protected]>
Contributor
Author
|
However, this situation may lead to fscache duplicating cached data. There are two possible solutions:
|
ktock
approved these changes
Jul 24, 2025
Member
ktock
left a comment
ktock
left a comment
There was a problem hiding this comment.
LGTM. CI flakiness doesn't seem to related to this PR. I'll work on fixing that in a separated patch.
Member
Let's take the approach 1 for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR #2076, in scenarios where the process restarts unexpectedly (such as due to OOM), restoring a remote snapshot may fail if the target directory already exists. For example:
This PR adjusts the logic in restoreRemoteSnapshot so that if mkdir fails because the directory already exists, it is treated as a result of an ungraceful shutdown and the process continues.