Make graceful restarting available in wider configurations#2077
Merged
AkihiroSuda merged 3 commits intocontainerd:mainfrom Jul 10, 2025
Merged
Make graceful restarting available in wider configurations#2077AkihiroSuda merged 3 commits intocontainerd:mainfrom
AkihiroSuda merged 3 commits intocontainerd:mainfrom
Conversation
ktock
force-pushed
the
gracefulrestart-b
branch
3 times, most recently
from
71d4640 to
c18b7b1
Compare
AkihiroSuda
reviewed
Jul 9, 2025
fs/layer/layer.go
Outdated
|
|
||
| // Close is the same as Done. But this evicts the resources related to this Layer immediately. | ||
| // This can be used for cleaning up resources on unmount. | ||
| Close() |
Member
There was a problem hiding this comment.
AkihiroSuda
reviewed
Jul 9, 2025
script/integration/test.sh
Outdated
|
|
||
| RUN apt-get update -y && \ | ||
| apt-get --no-install-recommends install -y iptables jq && \ | ||
| apt-get install -y iptables jq netcat && \ |
Member
There was a problem hiding this comment.
Why drop --no-install-recommends
ktock
force-pushed
the
gracefulrestart-b
branch
2 times, most recently
from
f0715d7 to
561aa03
Compare
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2076
Following up #1892
When stargz snapshotter receives SIGINT, it perform the graceful exit with explicitly unmounting the mountpoints and releasing the associated resources.
This PR makes this avilablable also in the following situations
This PR also adds docs about how to gracefully kill and restart Stargz Snapshotter under different configurations.