Skip to content

Fix log message in refnode.Lookup#1595

Merged
ktock merged 1 commit intocontainerd:mainfrom
iain-macdonald:logmsg
Mar 15, 2024
Merged

Fix log message in refnode.Lookup#1595
ktock merged 1 commit intocontainerd:mainfrom
iain-macdonald:logmsg

Conversation

@iain-macdonald
Copy link
Copy Markdown
Contributor

This message is logged within refnode.Lookup but mentions rootnode.Lookup in the message making it a confusing to distinguish between the other, identical message on line 180.

Copy link
Copy Markdown
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iain-macdonald
Copy link
Copy Markdown
Contributor Author

No problem, do you mind merging this, Kohei? I can't without write access :-)

@ktock
Copy link
Copy Markdown
Member

ktock commented Mar 15, 2024

Could you rebase this patch on the latest main commit to pass CI?

@iain-macdonald
Copy link
Copy Markdown
Contributor Author

Could you rebase this patch on the latest main commit to pass CI?

Yup, done.

@ktock ktock merged commit 06a192e into containerd:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants