Add parameters option for protoc opts#54
Conversation
dmcgowan
force-pushed
the
add-parameter-support
branch
from
670d11c to
a8820f0
Compare
|
@samuelkarp Does it make sense to support source_relative by having this change? |
|
I'd like to use TOML's key/value pairs like rather than introducing Would it be something people would configure per prefixes, like https://github.com/containerd/containerd/blob/0fac756b645275aa855f3d5ab7d1dfd74fadc1ed/Protobuild.toml#L16? |
|
@kzys I like that, I'm not quite sure how to achieve that though with the library |
dmcgowan
force-pushed
the
add-parameter-support
branch
from
a8820f0 to
77e5d18
Compare
|
Updated. The parameters key has to stay but they can be specified like [parameters.go-ttrpc]
prefix = "TTRPC"or [overrides.parameters.go-ttrpc]
prefix = "TTRPC" |
kzys
left a comment
kzys
left a comment
There was a problem hiding this comment.
Looks good!
@samuelkarp Can you take a look? Would it cover the source_relative use case? I believe it does.
Adds support for custom parameters to be passed to the protoc generators. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
add-parameter-support
branch
from
77e5d18 to
6d693b6
Compare
|
@kzys I confirmed this could be used to add the option, but would still need logic to handle the go path accordingly and I found another issue with relative includes. This would allow implementation though without adding a new configuration option since the parameter for the go generator could be checked for directly. |
|
@kzys Almost; there's still an issue with the |
3 participants
Adds support for custom parameters to be passed to the protoc generators.
This is part of an effort to generate ttrpc services alongside existing grpc services. A custom parameter will be added to the ttrpc generator which allows prefixing the TTRPC service names when they are generated.
Configuration would look something like...