Fix overrides on Windows #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
force-pushed
the
test-windows
branch
3 times, most recently
from
465e6a2 to
92b6d20
Compare
Protobuild was assuming that canonicalized relative file paths and Go import paths are the same. This is not true on Windows where the former uses `\` but the latter uses (as like other OSes) `/`. This change fixes the issue and adds some tests around the implementation to prevent regressions. Fixes containerd#47. Signed-off-by: Kazuyoshi Kato <[email protected]>
dmcgowan
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuild was assuming that canonicalized relative file paths and
Go import paths are the same. This is not true on Windows where
the former uses
\but the latter uses (as like other OSes)/.This change fixes the issue and adds some tests around the
implementation to prevent regressions.
Fixes #47.