Skip to content

Support specifying go-mod-tidy-flags#4

Merged
estesp merged 1 commit intomainfrom
go-mod-tidy-compat
Jan 25, 2022
Merged

Support specifying go-mod-tidy-flags#4
estesp merged 1 commit intomainfrom
go-mod-tidy-compat

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Jan 24, 2022 •
edited
Loading

For containerd/nerdctl#718 (comment)

  To proceed despite packages unresolved in go 1.16:
  	go mod tidy -e
  If reproducibility with go 1.16 is not needed:
  	go mod tidy -compat=1.17
  For other options, see:
  	https://golang.org/doc/modules/pruning

cc @junnplus

@junnplus
Copy link
Copy Markdown
Member

junnplus commented Jan 24, 2022

LGTM

estesp
estesp approved these changes Jan 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda marked this pull request as draft January 25, 2022 09:33
@AkihiroSuda AkihiroSuda changed the title go mod tidy: add -compat=1.17 Support specifying go-mod-tidy-flags Jan 25, 2022
AkihiroSuda added a commit to AkihiroSuda/nerdctl that referenced this pull request Jan 25, 2022
@AkihiroSuda
[DNM] Test containerd/project-checks#4
6aeca07 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 25, 2022
Closed
AkihiroSuda added a commit to AkihiroSuda/nerdctl that referenced this pull request Jan 25, 2022
@AkihiroSuda
[DNM] Test containerd/project-checks#4
7fc9eb4 
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda added a commit to AkihiroSuda/nerdctl that referenced this pull request Jan 25, 2022
@AkihiroSuda
[DNM] Test containerd/project-checks#4
5465ab5 
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda added a commit to AkihiroSuda/nerdctl that referenced this pull request Jan 25, 2022
@AkihiroSuda
[DNM] Test containerd/project-checks#4
8e535c4 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Support specifying go-mod-tidy-flags
5e11734 
e.g., `-compat=1.17`

Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda added a commit to AkihiroSuda/nerdctl that referenced this pull request Jan 25, 2022
@AkihiroSuda
[DNM] Test containerd/project-checks#4
7958fc2 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda marked this pull request as ready for review January 25, 2022 09:59
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Jan 25, 2022 •
edited
Loading

Changed to support an optional input string go-mod-tidy-flags

✅ Passing: https://github.com/containerd/nerdctl/runs/4934951472?check_suite_focus=true

fuweid
fuweid approved these changes Jan 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Jan 25, 2022

Let me release v1.0.2 after merging this

estesp
estesp approved these changes Jan 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a0c3be2 into main Jan 25, 2022
@fuweid fuweid deleted the go-mod-tidy-compat branch January 25, 2022 15:24
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AkihiroSuda @junnplus @estesp @fuweid