Skip to content

script/validate/vendor: remove the double quotes#38

Merged
estesp merged 1 commit intocontainerd:masterfrom
fuweid:me-remove-quote
Oct 21, 2019
Merged

script/validate/vendor: remove the double quotes#38
estesp merged 1 commit intocontainerd:masterfrom
fuweid:me-remove-quote

Conversation

@fuweid
Copy link
Member

@fuweid fuweid commented Oct 21, 2019

git-status will take "vendor/ go.mod go.sum" as one path. we should
remove the double quotes.

Signed-off-by: Wei Fu [email protected]

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

shellcheck will probably complain about this; should we add a comment to suppress it (preventing someone from accidentally changing it back?)

# shellcheck disable=SC2046

(on my phone so haven't checked if it complains)

git-status will take "vendor/ go.mod go.sum" as one path. we should
remove the double quotes.

Signed-off-by: Wei Fu <[email protected]>
@fuweid
Copy link
Member Author

fuweid commented Oct 21, 2019

shellcheck will probably complain about this; should we add a comment to suppress it (preventing someone from accidentally changing it back?)

# shellcheck disable=SC2046

(on my phone so haven't checked if it complains)

Sure. Updated

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 6879c80 into containerd:master Oct 21, 2019
@fuweid fuweid deleted the me-remove-quote branch October 21, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants