Revert "feat: Remove DumpFile operations"#625
Merged
imeoer merged 3 commits intocontainerd:mainfrom Dec 11, 2024
Merged
Conversation
This reverts commit 29243e3. For the design of non-persistent configuration, we need to consider more factors and cannot simply place the configuration files in the local metadata database.
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
==========================================
+ Coverage 21.29% 21.39% +0.09%
==========================================
Files 122 122
Lines 13678 13617 -61
==========================================
Hits 2913 2913
+ Misses 10443 10383 -60
+ Partials 322 321 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 29243e3.
For the design of non-persistent configuration, we need to consider more factors
and cannot simply place the configuration files in the local metadata database.