snapshotter: add flag to specify nydus-overlayfs path#615
Merged
imeoer merged 1 commit intocontainerd:mainfrom Sep 9, 2024
Merged
snapshotter: add flag to specify nydus-overlayfs path#615imeoer merged 1 commit intocontainerd:mainfrom
imeoer merged 1 commit intocontainerd:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 22.07% 22.07%
=======================================
Files 122 122
Lines 10746 10766 +20
=======================================
+ Hits 2372 2377 +5
- Misses 8054 8068 +14
- Partials 320 321 +1
|
imeoer
reviewed
Sep 5, 2024
Collaborator
imeoer
left a comment
imeoer
left a comment
There was a problem hiding this comment.
LGTM! Maybe also add the option into misc/snapshotter/config.toml. :)
katexochen
force-pushed
the
nydus-overlayfs-path
branch
from
036734a to
b97feed
Compare
Contributor
Author
Thanks, done! :) |
This allows installation of multiple nydus-overlayfs versions on the same machine. Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
nydus-overlayfs-path
branch
from
b97feed to
50a833f
Compare
imeoer
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows installation of multiple nydus-overlayfs versions on the same machine.