chore: clean and unify nolint directives

marquiz · marquiz · commit 21741b9ee40d · 2025-08-27T15:54:34.000+03:00
Drop unnecessary nolint directives and unify the style of remaining ones
to match the rest of the codebase (and the golangci-lint documentation).

Signed-off-by: Markus Lehtonen &lt;markus.lehtonen@intel.com&gt;
diff --git a/pkg/adaptation/api.go b/pkg/adaptation/api.go
@@ -25,7 +25,6 @@ import (
 //
 
 // Aliased request/response/event types for api/api.proto.
-// nolint
 type (
 	RegisterPluginRequest    = api.RegisterPluginRequest
 	RegisterPluginResponse   = api.Empty
@@ -102,7 +101,8 @@ type (
 )
 
 // Aliased consts for api/api.proto.
-// nolint
+//
+//nolint:revive // ignore const naming from auto-generated code
 const (
 	Event_UNKNOWN                       = api.Event_UNKNOWN
 	Event_RUN_POD_SANDBOX               = api.Event_RUN_POD_SANDBOX
@@ -134,7 +134,6 @@ const (
 )
 
 // Aliased types for api/optional.go.
-// nolint
 type (
 	OptionalString   = api.OptionalString
 	OptionalInt      = api.OptionalInt
@@ -147,7 +146,6 @@ type (
 )
 
 // Aliased functions for api/optional.go.
-// nolint
 var (
 	String   = api.String
 	Int      = api.Int
@@ -160,7 +158,6 @@ var (
 )
 
 // Aliased functions for api/types.go.
-// nolint
 var (
 	FromOCIMounts          = api.FromOCIMounts
 	FromOCIHooks           = api.FromOCIHooks
diff --git a/pkg/api/event.go b/pkg/api/event.go
@@ -26,7 +26,6 @@ const (
 	ValidEvents = EventMask((1 << (Event_LAST - 1)) - 1)
 )
 
-// nolint
 type (
 	// Define *Request/*Response type aliases for *Event/Empty pairs.
 
diff --git a/pkg/net/multiplex/mux.go b/pkg/net/multiplex/mux.go
@@ -363,7 +363,6 @@ func (m *mux) setError(err error) {
 	})
 }
 
-// nolint
 func (m *mux) error() error {
 	m.errOnce.Do(func() {
 		if m.err == nil {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ const (`
`26`	`26`	`ValidEvents = EventMask((1 << (Event_LAST - 1)) - 1)`
`27`	`27`	`)`
`28`	`28`
`29`		`-// nolint`
`30`	`29`	`type (`
`31`	`30`	`// Define Request/Response type aliases for *Event/Empty pairs.`
`32`	`31`
Original file line number	Diff line number	Diff line change
`@@ -363,7 +363,6 @@ func (m *mux) setError(err error) {`
`363`	`363`	`})`
`364`	`364`	`}`
`365`	`365`
`366`		`-// nolint`
`367`	`366`	`func (m *mux) error() error {`
`368`	`367`	`m.errOnce.Do(func() {`
`369`	`368`	`if m.err == nil {`