Add nolint directives

marquiz · marquiz · commit 1a50ff585624 · 2025-08-29T13:38:52.000+03:00
Silence golangci-lint v2.4 errors that we don't want to fix.

Signed-off-by: Markus Lehtonen &lt;markus.lehtonen@intel.com&gt;
diff --git a/pkg/adaptation/api.go b/pkg/adaptation/api.go
@@ -25,6 +25,8 @@ import (
 //
 
 // Aliased request/response/event types for api/api.proto.
+//
+//nolint:revive // revive thinks the comment is for the exported type below
 type (
 	RegisterPluginRequest    = api.RegisterPluginRequest
 	RegisterPluginResponse   = api.Empty
@@ -134,6 +136,8 @@ const (
 )
 
 // Aliased types for api/optional.go.
+//
+//nolint:revive // revive thinks the comment is for the exported type below
 type (
 	OptionalString   = api.OptionalString
 	OptionalInt      = api.OptionalInt
diff --git a/pkg/adaptation/builtin/plugin.go b/pkg/adaptation/builtin/plugin.go
@@ -24,13 +24,17 @@ import (
 
 // BuiltinPlugin implements the NRI API and runs in-process
 // within the container runtime.
+//
+//nolint:revive // tautology builtin.Builtin*
 type BuiltinPlugin struct {
 	Base     string
 	Index    string
 	Handlers BuiltinHandlers
 }
 
 // BuiltinHandlers contains request handlers for the builtin plugin.
+//
+//nolint:revive // tautology builtin.Builtin*
 type BuiltinHandlers struct {
 	Configure            func(context.Context, *api.ConfigureRequest) (*api.ConfigureResponse, error)
 	Synchronize          func(context.Context, *api.SynchronizeRequest) (*api.SynchronizeResponse, error)
diff --git a/pkg/api/event.go b/pkg/api/event.go
@@ -26,6 +26,7 @@ const (
 	ValidEvents = EventMask((1 << (Event_LAST - 1)) - 1)
 )
 
+//nolint:revive // exported type should have comment
 type (
 	// Define *Request/*Response type aliases for *Event/Empty pairs.
 
diff --git a/pkg/api/owners.go b/pkg/api/owners.go
@@ -14,6 +14,9 @@
    limitations under the License.
 */
 
+// TODO: Add comments to exported methods and functions.
+//
+//nolint:revive // exported symbols should have comments
 package api
 
 import (
diff --git a/pkg/api/plugin.go b/pkg/api/plugin.go
@@ -51,6 +51,7 @@ func CheckPluginIndex(idx string) error {
 	if len(idx) != 2 {
 		return fmt.Errorf("invalid plugin index %q, must be 2 digits", idx)
 	}
+	//nolint:staticcheck // could apply De Morgan's law
 	if !('0' <= idx[0] && idx[0] <= '9') || !('0' <= idx[1] && idx[1] <= '9') {
 		return fmt.Errorf("invalid plugin index %q (not [0-9][0-9])", idx)
 	}
diff --git a/pkg/api/strip.go b/pkg/api/strip.go
@@ -223,7 +223,7 @@ func (c *LinuxCPU) Strip() *LinuxCPU {
 		return nil
 	}
 
-	empty := true
+	empty := true //nolint:staticcheck // could merge conditional assignment below to variable definition
 
 	if c.Shares != nil {
 		empty = false
@@ -262,7 +262,7 @@ func (m *LinuxMemory) Strip() *LinuxMemory {
 		return nil
 	}
 
-	empty := true
+	empty := true //nolint:staticcheck // could merge conditional assignment below to variable definition
 
 	if m.Limit != nil {
 		empty = false

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ const (`
`26`	`26`	`ValidEvents = EventMask((1 << (Event_LAST - 1)) - 1)`
`27`	`27`	`)`
`28`	`28`
	`29`	`+//nolint:revive // exported type should have comment`
`29`	`30`	`type (`
`30`	`31`	`// Define Request/Response type aliases for *Event/Empty pairs.`
`31`	`32`
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ func CheckPluginIndex(idx string) error {`
`51`	`51`	`if len(idx) != 2 {`
`52`	`52`	`return fmt.Errorf("invalid plugin index %q, must be 2 digits", idx)`
`53`	`53`	`}`
	`54`	`+ //nolint:staticcheck // could apply De Morgan's law`
`54`	`55`	`if !('0' <= idx[0] && idx[0] <= '9') \|\| !('0' <= idx[1] && idx[1] <= '9') {`
`55`	`56`	`return fmt.Errorf("invalid plugin index %q (not [0-9][0-9])", idx)`
`56`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ func (c LinuxCPU) Strip() LinuxCPU {`
`223`	`223`	`return nil`
`224`	`224`	`}`
`225`	`225`
`226`		`- empty := true`
	`226`	`+ empty := true //nolint:staticcheck // could merge conditional assignment below to variable definition`
`227`	`227`
`228`	`228`	`if c.Shares != nil {`
`229`	`229`	`empty = false`
`@@ -262,7 +262,7 @@ func (m LinuxMemory) Strip() LinuxMemory {`
`262`	`262`	`return nil`
`263`	`263`	`}`
`264`	`264`
`265`		`- empty := true`
	`265`	`+ empty := true //nolint:staticcheck // could merge conditional assignment below to variable definition`
`266`	`266`
`267`	`267`	`if m.Limit != nil {`
`268`	`268`	`empty = false`