Repository navigation
pkg/identifiers: add tests for ValidateDockerCompat - #5088
Merged
AkihiroSuda merged 1 commit intoAug 1, 2026
Merged
AkihiroSuda merged 1 commit into
AkihiroSuda merged 1 commit into
Conversation
nikolauspschuetz
force-pushed
the
test-identifiers-validatedockercompat
branch
2 times, most recently
from
July 21, 2026 14:36
659e6c2 to
f558bab
Compare
nikolauspschuetz
marked this pull request as ready for review
July 22, 2026 21:46
AkihiroSuda
reviewed
Aug 1, 2026
Member
There was a problem hiding this comment.
The file name should be <IMPLEMENTATION>_test.go, i.e., validate_test.go
pkg/identifiers had no test coverage, though ValidateDockerCompat gates container, volume, and network names across the codebase. Add table-driven tests for the accepted charset, the Docker-compatible two-character minimum, leading-separator and invalid-character rejection, and the empty case, asserting both the message and the wrapped errdefs.ErrInvalidArgument. Signed-off-by: Nikolaus Schuetz <[email protected]>
nikolauspschuetz
force-pushed
the
test-identifiers-validatedockercompat
branch
from
August 1, 2026 19:33
f558bab to
99ad6bd
Compare
AkihiroSuda
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/identifiershad no tests, even thoughValidateDockerCompatvalidates container, volume, and network names throughout the codebase. This adds table-driven coverage: the accepted charset (alphanumeric plus_.-), the Docker-compatible two-character minimum, rejection of leading separators and invalid characters, and the empty-string case. Each error case also asserts the wrappederrdefs.ErrInvalidArgument.Test-only, no behavior change.