fix: output log even log is rotated#3200
Merged
fahedouch merged 2 commits intocontainerd:mainfrom Aug 5, 2024
Merged
Conversation
xyz-li
force-pushed
the
main
branch
5 times, most recently
from
769c82a to
c1c5879
Compare
xyz-li
changed the title
Contributor
Author
fahedouch
reviewed
Jul 7, 2024
fahedouch
reviewed
Jul 7, 2024
xyz-li
force-pushed
the
main
branch
18 times, most recently
from
bdd3ce4 to
80b31e1
Compare
xyz-li
force-pushed
the
main
branch
6 times, most recently
from
063b40a to
278e20e
Compare
xyz-li
changed the title
xyz-li
changed the title
fahedouch
reviewed
Jul 20, 2024
fahedouch
reviewed
Jul 21, 2024
xyz-li
force-pushed
the
main
branch
3 times, most recently
from
53d517e to
b6f412b
Compare
Member
|
please check #3259 (comment) |
Signed-off-by: xyz-li <[email protected]>
Signed-off-by: xyz-li <[email protected]>
xyz-li
commented
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bug nerdctl not outputting log after log file rotation.
Fixes: #3199