Add Inspect image by fahedouch · Pull Request #239 · containerd/nerdctl

fahedouch · 2021-06-04T17:07:07Z

same as docker image inspect and docker inspect

related ticket #222

AkihiroSuda · 2021-06-11T05:02:28Z

+// Not compatible with `docker image inspect`.
+type Image struct {
+	images.Image
+	ImageSpec  interface{} `json:"Image"`


Why interface{}?

also json:"ImageSpec"

@AkihiroSuda interface{}. because i want to avoid using the ocispec.Image in this native containerd object

Why do you want to avoid it?

it looks cleaner if i use an interface here and map this interface to ocispec.Image in dockercompat may be I'm wrong. Anyway I made the change

AkihiroSuda · 2021-06-16T01:54:25Z

+		defaultBashComplete(clicontext)
+		return
+	}
+	// show container names


s/container/image/

AkihiroSuda · 2021-06-16T01:55:07Z

+		}
+
+		if ni != 0 && nc != 0 {
+			return errors.Errorf("Multiple IDs found with provided prefix: %s", req)


error should start with a lower char

AkihiroSuda · 2021-06-16T01:57:38Z

+
+	i.ID = n.Descriptor.Digest.String()
+
+	s := []string{n.Image.Name, "@", n.Image.Target.Digest.String()}


why not use fmt.Sprintf

AkihiroSuda · 2021-06-16T01:58:30Z

+	i.ID = n.Descriptor.Digest.String()
+
+	s := []string{n.Image.Name, "@", n.Image.Target.Digest.String()}
+	i.RepoTags, i.RepoDigests = parseImageReferences([]string{strings.Join(s, "")})


We already know the digest, no need to "parse" it

I let you check :)

AkihiroSuda · 2021-06-16T01:59:31Z

+	}
+
+	n.Descriptor = config
+	n.Image.Name = image.Name


Why not just set n.Image = image

AkihiroSuda · 2021-06-17T02:00:37Z

+	}
+
+	var tag string
+	nameWithTagSplit := strings.Split(imgName, ":")


https://pkg.go.dev/github.com/containerd/containerd/reference/docker#TrimNamed

(I noticed that the code is not new in this PR, so this can be done later)

AkihiroSuda · 2021-06-17T02:00:49Z

+	}
+	repository := strings.TrimSuffix(imgName, ":"+tag)
+	repository = strings.TrimPrefix(repository, "docker.io/library/")
+	repository = strings.TrimPrefix(repository, "docker.io/")


https://pkg.go.dev/github.com/containerd/containerd/reference/docker#FamiliarName

same for this, this will be done in new PR!

AkihiroSuda · 2021-06-17T02:07:07Z

As usual, please squash commits

Signed-off-by: fahed dorgaa <[email protected]>

AkihiroSuda · 2021-06-19T08:57:46Z

Added commit bcd29a7

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda

Thanks

fahedouch marked this pull request as draft June 4, 2021 17:07

fahedouch changed the title ~~Inspect image~~ Add Inspect image Jun 4, 2021

fahedouch changed the title ~~Add Inspect image~~ [WIP] Add Inspect image Jun 4, 2021

fahedouch force-pushed the inspect-image branch from fe4c4e9 to 7c73e7e Compare June 9, 2021 14:57

fahedouch marked this pull request as ready for review June 9, 2021 14:58

fahedouch force-pushed the inspect-image branch from 7c73e7e to 43bbd24 Compare June 9, 2021 15:00

fahedouch changed the title ~~[WIP] Add Inspect image~~ Add Inspect image Jun 10, 2021

fahedouch force-pushed the inspect-image branch 2 times, most recently from bfa9d38 to 4d8a1c7 Compare June 10, 2021 17:24