Skip to content

fix json file logging filenames#1211

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
fahedouch:fix-json-file-logging-filenames
Jul 10, 2022
Merged

fix json file logging filenames#1211
AkihiroSuda merged 1 commit intocontainerd:masterfrom
fahedouch:fix-json-file-logging-filenames

Conversation

@fahedouch
Copy link
Member

@fahedouch fahedouch commented Jul 8, 2022

I released the v0.1.0 of go-logrotate

this will fix #1077

Signed-off-by: fahed dorgaa [email protected]

@fahedouch fahedouch marked this pull request as draft July 8, 2022 19:26
@fahedouch fahedouch force-pushed the fix-json-file-logging-filenames branch from 19ff023 to 396963e Compare July 10, 2022 19:24
@fahedouch
Copy link
Member Author

I made a patch for go-logrorate v0.1.1 to init supporting windows and freebsd runtime Os

@fahedouch fahedouch force-pushed the fix-json-file-logging-filenames branch from 2a3fd99 to 8716087 Compare July 10, 2022 19:29
@fahedouch fahedouch force-pushed the fix-json-file-logging-filenames branch from 8716087 to 41c63f3 Compare July 10, 2022 19:29
@fahedouch fahedouch marked this pull request as ready for review July 10, 2022 19:30
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 3da97b1 into containerd:master Jul 10, 2022
@AkihiroSuda AkihiroSuda added this to the v0.22.0 milestone Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logging: json-file filenames are incompatible with Docker

2 participants