container logs do not invoke logs cmd#1115
Closed
fahedouch wants to merge 3 commits intocontainerd:mainfrom
Closed
container logs do not invoke logs cmd#1115fahedouch wants to merge 3 commits intocontainerd:mainfrom
fahedouch wants to merge 3 commits intocontainerd:mainfrom
Conversation
fahedouch
changed the title
fahedouch
force-pushed
the
container-logging-without-invoke-logs-cmd
branch
2 times, most recently
from
a6afce6 to
8031641
Compare
fahedouch
changed the title
fahedouch
force-pushed
the
container-logging-without-invoke-logs-cmd
branch
from
9c8c3d0 to
91c543f
Compare
Signed-off-by: Fahed DORGAA <[email protected]>
fahedouch
force-pushed
the
container-logging-without-invoke-logs-cmd
branch
from
91c543f to
49e5431
Compare
Member
Signed-off-by: Fahed DORGAA <[email protected]>
Signed-off-by: Fahed DORGAA <[email protected]>
Contributor
|
@fahedouch #1071 was fixed, but I am wondering if there is still value in your work here. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes :
nerdctl compose logsno longer rely onnerdctl logsnerdctl compose uplog output no longer rely onnerdctl logsnerdctl logsAnd
fixing #1071
Signed-off-by: Fahed DORGAA [email protected]