Implement v2 interface based on slog#13
Open
dmcgowan wants to merge 1 commit intocontainerd:mainfrom
Open
Conversation
Add v2 interface as a new module alongside v1. The v2 inteface is designed for maximum compatibility purely using slog. Signed-off-by: Derek McGowan <[email protected]>
Member
austinvazquez
left a comment
austinvazquez
left a comment
There was a problem hiding this comment.
CI will need some work for the new module, but that can be follow-up work.
In my opinion, the only block is the frame counting fix.
| if ctx == nil { | ||
| ctx = context.Background() | ||
| } | ||
| logger.LogAttrs(ctx, level, msg, entry.attr...) |
Member
There was a problem hiding this comment.
This will be off by 1 frame count for the source. We will need to copy up some of the logging code from slog library to fix it.
| return logger.(*Entry) | ||
| } | ||
| return &Entry{ | ||
| logger: slog.Default(), |
Member
There was a problem hiding this comment.
Could consider lazy evaluation of logger here. i.e. leave logger as nil.
// Log level, format, and handler configuration should be done directly
// through [log/slog] using [slog.SetDefault] before using this package.To be fair, the package doc clear states all log configuration should be done before package use, but in this case it's not too inconsequential to defer the evaluation. All the log functions already account for nil logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add v2 interface as a new module alongside v1. The v2 inteface is designed for maximum compatibility purely using slog.
Since v1 and v2 will both be maintained, using the subdirectory approach for the v2 interface seems the cleanest. This code will very rarely change and may become irrelevant once directly using slog API becomes more common.
Closes #2