Skip to content

images: prepare for typeurl.Any#72

Merged
stefanberger merged 1 commit intocontainerd:masterfrom
kzys:typeurl
Mar 22, 2022
Merged

images: prepare for typeurl.Any#72
stefanberger merged 1 commit intocontainerd:masterfrom
kzys:typeurl

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Mar 22, 2022

typeurl.MarshalAny returns typeurl.Any since
containerd/typeurl#32.

Signed-off-by: Kazuyoshi Kato [email protected]

typeurl.MarshalAny returns typeurl.Any since
containerd/typeurl#32.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@stefanberger
Copy link
Copy Markdown
Contributor

It passes the tests so it doesn't seem to have any side effects...

@kzys
Copy link
Copy Markdown
Member Author

kzys commented Mar 22, 2022

It passes the tests so it doesn't seem to have any side effects...

Yes. fromAny() is essentially no-op since this package is only passing *types.Any. This will help changes like containerd/containerd#6706.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanberger stefanberger merged commit 7eff50e into containerd:master Mar 22, 2022
kzys pushed a commit to kzys/containerd that referenced this pull request Mar 22, 2022
…image-spec

- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit to kzys/containerd that referenced this pull request Mar 22, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit to kzys/containerd that referenced this pull request Mar 22, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
dims pushed a commit to dims/containerd-api-only that referenced this pull request Mar 26, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
dims pushed a commit to dims/containerd-api-only that referenced this pull request Mar 26, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
akhilerm pushed a commit to akhilerm/containerd-api that referenced this pull request May 23, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
akhilerm pushed a commit to akhilerm/containerd-api that referenced this pull request Jun 22, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
akhilerm pushed a commit to akhilerm/containerd-test that referenced this pull request Feb 22, 2023
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>

Containerd-test-commit: e569306
kiashok pushed a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade
  (see containerd/imgcrypt#72)
- Upgrade github.com/opencontainers/image-spec since imgcrypto needs at
  least 1.0.2.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants