Skip to content

images: Implement ConvertFunc for image en- and decryption#49

Merged
stefanberger merged 1 commit intocontainerd:masterfrom
stefanberger:stefanberger/layerconvertfunc
May 13, 2021
Merged

images: Implement ConvertFunc for image en- and decryption#49
stefanberger merged 1 commit intocontainerd:masterfrom
stefanberger:stefanberger/layerconvertfunc

Conversation

@stefanberger
Copy link
Copy Markdown
Contributor

Signed-off-by: Stefan Berger [email protected]

@stefanberger stefanberger force-pushed the stefanberger/layerconvertfunc branch from f87d7d6 to 035be61 Compare May 13, 2021 14:54
Comment thread images/encryption/encryption.go Outdated
// GetImageEncryptConverter returns a converter function for image decryption
func GetImageDecryptConverter(cc *encconfig.CryptoConfig, lf LayerFilter) converter.ConvertFunc {
return func(ctx context.Context, cs content.Store, desc ocispec.Descriptor) (*ocispec.Descriptor, error) {
newDesc, _, err := EncryptImage(ctx, cs, desc, cc, lf)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Decrypt?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@stefanberger stefanberger force-pushed the stefanberger/layerconvertfunc branch from 035be61 to 5340a4f Compare May 13, 2021 15:02
@stefanberger stefanberger force-pushed the stefanberger/layerconvertfunc branch from 5340a4f to b5e4c03 Compare May 13, 2021 15:03
@lumjjb lumjjb requested a review from AkihiroSuda May 13, 2021 16:01
Copy link
Copy Markdown
Collaborator

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stefanberger stefanberger merged commit 8d466d7 into containerd:master May 13, 2021
@stefanberger stefanberger deleted the stefanberger/layerconvertfunc branch May 13, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants