Migrate to GitHub Actions for CI#35
Merged
stefanberger merged 2 commits intocontainerd:masterfrom Mar 2, 2021
Merged
Conversation
Signed-off-by: Phil Estes <[email protected]>
Signed-off-by: Phil Estes <[email protected]>
Contributor
|
Can we now also remove the vendor directory? |
Contributor
|
Someone with more rights to change the settings of this project should probably enable github actions so that we see them running form now on. |
Contributor
|
@estesp Thanks for the PR! |
Member
Author
|
As soon as this is merged you will automatically start to see the actions runs on every future PR and merge. No settings need to be changed. At that point we can remove the Travis config file and that will automatically stop Travis from running |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables GitHub actions for both Linux and Windows and runs the same checks/tests as currently implemented via Travis and Appveyor. If acceptable, Travis and Appveyor can be removed once validated; a successful run is here in my fork: https://github.com/estesp/imgcrypt/actions/runs/615320837