Skip to content

go.mod: github.com/containerd/containerd/v2 v2.0.0-rc.1#148

Closed
AkihiroSuda wants to merge 4 commits intocontainerd:mainfrom
AkihiroSuda:containerd-v2
Closed

go.mod: github.com/containerd/containerd/v2 v2.0.0-rc.1#148
AkihiroSuda wants to merge 4 commits intocontainerd:mainfrom
AkihiroSuda:containerd-v2

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

  • github.com/containerd/containerd/{containers,images,...} -> github.com/containerd/containerd/v2/core/{containers,images,...}
  • github.com/containerd/containerd/{errdefs,logs,platforms} -> github.com/containerd/{errdefs,logs,platforms}
  • github.com/containerd/typeurl -> github.com/containerd/typeurl/v2
  • github.com/urfave/cli -> github.com/urfave/cli/v2 (See Migrate Urfave CLI from v1 to v2 containerd#9809)

@AkihiroSuda
Copy link
Copy Markdown
Member Author

--- FAIL: TestInit (0.00s)
    payload_test.go:28: failed to detect gogo: false
FAIL
FAIL	github.com/containerd/imgcrypt/images/encryption	0.006s

https://github.com/containerd/imgcrypt/actions/runs/8448335008/job/23140237920?pr=148

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this file, but not sure if this is correct

@AkihiroSuda AkihiroSuda requested a review from kzys March 27, 2024 09:44
@AkihiroSuda AkihiroSuda force-pushed the containerd-v2 branch 2 times, most recently from c6c0382 to feb5efb Compare March 27, 2024 10:25
@AkihiroSuda AkihiroSuda force-pushed the containerd-v2 branch 2 times, most recently from dc18835 to 73a87eb Compare March 27, 2024 11:00
@AkihiroSuda AkihiroSuda marked this pull request as draft March 27, 2024 11:01
@AkihiroSuda

This comment was marked as resolved.

@AkihiroSuda AkihiroSuda force-pushed the containerd-v2 branch 4 times, most recently from f22bad5 to 5daba92 Compare March 27, 2024 14:26
@AkihiroSuda
Copy link
Copy Markdown
Member Author

Testing creation of container from encrypted image
Encrypting docker.io/library/bash:latest to docker.io/library/bash:enc
ctr: content digest sha256:4f02cf678855fbab38b3638a131fb83cbbea5e1f815dce93c2d8a9d12796e541: not found
Error: Image encryption with JWE failed; public key: jwe:/tmp/tmp.HZ76rjzgUp/mypubkey.jwk

https://github.com/containerd/imgcrypt/actions/runs/8453433526/job/23156116537?pr=148

- github.com/containerd/containerd/{containers,images,...} -> github.com/containerd/containerd/v2/core/{containers,images,...}
- github.com/containerd/containerd/{errdefs,logs,platforms} -> github.com/containerd/{errdefs,logs,platforms}
- github.com/containerd/typeurl -> github.com/containerd/typeurl/v2
- github.com/urfave/cli -> github.com/urfave/cli/v2 (See containerd/containerd PR 9809)
- github.com/gogo/protobuf -> github.com/containerd/containerd/v2/protobuf

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda changed the title go.mod: github.com/containerd/containerd/v2 v2.0.0-rc.0 go.mod: github.com/containerd/containerd/v2 v2.0.0-rc.1 Apr 25, 2024
@yylt
Copy link
Copy Markdown

yylt commented May 13, 2024

the failed about CI test may related to the #69

@yylt
Copy link
Copy Markdown

yylt commented May 13, 2024

/cc @stefanberger

@dmcgowan
Copy link
Copy Markdown
Member

Carried in #157 with the tests fixed

@dmcgowan dmcgowan closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants