darwin: ignore fchown failure on darwin #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehajime
force-pushed
the
fix-darwin-fchown
branch
from
8e1877a to
71d217e
Compare
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 12.11% 12.06% -0.06%
==========================================
Files 7 7
Lines 652 655 +3
==========================================
Hits 79 79
- Misses 551 554 +3
Partials 22 22
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Sep 3, 2020
mikebrow
reviewed
Sep 4, 2020
io_unix.go
Outdated
| pipes = append(pipes, stdin) | ||
| if err = unix.Fchown(int(stdin.r.Fd()), uid, gid); err != nil { | ||
| return nil, errors.Wrap(err, "failed to chown stdin") | ||
| // XXX: can't chown to pipe on darwin |
Member
There was a problem hiding this comment.
Suggest using this skip with a warning or debug, and wrap the err: containerd/containerd@55d9550#diff-b3363345815845245ac7ce3ebbab476bR52-R57
for the comment suggest: TODO: revert with proper darwin solution, skipping for now as darwin chown is returning EINVAL on anonymous pipe
Contributor
Author
There was a problem hiding this comment.
updated with your suggestion. and also updated go.mod as it now uses logrus package.
io_unix.go
Outdated
| pipes = append(pipes, stdout) | ||
| if err = unix.Fchown(int(stdout.w.Fd()), uid, gid); err != nil { | ||
| return nil, errors.Wrap(err, "failed to chown stdout") | ||
| // XXX: can't chown to pipe on darwin |
fchown(2) on darwin returns EINVAL on anonymous pipe, thus this commit ignores this checks. Signed-off-by: Hajime Tazaki <[email protected]>
thehajime
force-pushed
the
fix-darwin-fchown
branch
from
71d217e to
52ac244
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fchown(2) on darwin returns EINVAL on anonymous pipe, thus this commit
ignores this checks.
This is related to the PR of containerd (containerd/containerd#4526).