Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containerd/go-cni
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.1
Choose a base ref
...
head repository: containerd/go-cni
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.2
Choose a head ref
  • 14 commits
  • 80 files changed
  • 4 contributors

Commits on Mar 16, 2021

  1. go.mod: github.com/stretchr/testify v1.6.1

    There's a v1.7.0 available as well, but other projects are still
    on v1.6.1, so sticking to that for now.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    e46fd50 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #62 from thaJeztah/bump_testify

    go.mod: github.com/stretchr/testify v1.6.1
    dmcgowan authored Mar 16, 2021
    Configuration menu
    Copy the full SHA
    799d387 View commit details
    Browse the repository at this point in the history
  3. TestLibCNITypeCurrent: fix ineffassign

        cni_test.go:127:8: ineffectual assignment to err (ineffassign)
            ipv4, err := types.ParseCIDR("10.0.0.1/24")
                  ^
        cni_test.go:153:8: ineffectual assignment to err (ineffassign)
            ipv4, err = types.ParseCIDR("10.0.0.2/24")
                  ^
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    7af6620 View commit details
    Browse the repository at this point in the history
  4. golint: add "nolint" for cni.CNIOpt and cni.CNIResult

    We should consider renaming, but may have to keep the old name as alias,
    given that this module already is at v1.x.x, so we cannot introduce
    breaking changes.
    
        opts.go:27:6: type name will be used as cni.CNIOpt by other packages, and that stutters; consider calling this Opt (golint)
        type CNIOpt func(c *libcni) error
             ^
        result.go:32:6: type name will be used as cni.CNIResult by other packages, and that stutters; consider calling this Result (golint)
        type CNIResult struct {
             ^
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    2285fea View commit details
    Browse the repository at this point in the history
  5. Move CI to use GitHub Actions

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    34348e7 View commit details
    Browse the repository at this point in the history
  6. Temporarily disable EXC0002 until GoDoc is fixed in this repo

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    30d0272 View commit details
    Browse the repository at this point in the history
  7. remove vendor directory

    This project is used as a library and doesn't produce binaries,
    in which case convention is to not use vendoring.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    7065daf View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Merge pull request #64 from thaJeztah/remove_vendor_and_update_cni

    Remove vendor directory
    estesp authored Mar 17, 2021
    Configuration menu
    Copy the full SHA
    b83843b View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Merge pull request #63 from thaJeztah/move_gha

    Move CI to use GitHub Actions
    AkihiroSuda authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    c77d4f1 View commit details
    Browse the repository at this point in the history
  2. Rename/deprecate CNIOpt and CNIResult (golint)

    To address golint;
    
        opts.go:27:6: type name will be used as cni.CNIOpt by other packages, and that stutters; consider calling this Opt (golint)
        type CNIOpt func(c *libcni) error
             ^
        result.go:32:6: type name will be used as cni.CNIResult by other packages, and that stutters; consider calling this Result (golint)
        type CNIResult struct {
             ^
    
    The old names are kept for backward compatiblity (as this module is
    already past v1.0.0)
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ce60981 View commit details
    Browse the repository at this point in the history
  3. Deprecate CNI.GetCNIResultFromResults()

    This function looks to be used internally only in CNI.Setup(),
    so mark it deprecated to discourage using it.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    6835ef2 View commit details
    Browse the repository at this point in the history
  4. Remove travis.yml

    Project has switched to GitHub actions, so we can now remove this
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    f8a5662 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #66 from thaJeztah/remove_travis

    Remove travis.yml
    estesp authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a8a934a View commit details
    Browse the repository at this point in the history
  6. Merge pull request #65 from thaJeztah/rename_types

    Rename/deprecate CNIOpt, CNIResult, CNI.GetCNIResultFromResults
    estesp authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b5e1823 View commit details
    Browse the repository at this point in the history
Loading