-
Notifications
You must be signed in to change notification settings - Fork 67
Comparing changes
Open a pull request
base repository: containerd/go-cni
base: v1.0.1
head repository: containerd/go-cni
compare: v1.0.2
- 14 commits
- 80 files changed
- 4 contributors
Commits on Mar 16, 2021
-
go.mod: github.com/stretchr/testify v1.6.1
There's a v1.7.0 available as well, but other projects are still on v1.6.1, so sticking to that for now. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e46fd50 - Browse repository at this point
Copy the full SHA e46fd50View commit details -
Merge pull request #62 from thaJeztah/bump_testify
go.mod: github.com/stretchr/testify v1.6.1
Configuration menu - View commit details
-
Copy full SHA for 799d387 - Browse repository at this point
Copy the full SHA 799d387View commit details -
TestLibCNITypeCurrent: fix ineffassign
cni_test.go:127:8: ineffectual assignment to err (ineffassign) ipv4, err := types.ParseCIDR("10.0.0.1/24") ^ cni_test.go:153:8: ineffectual assignment to err (ineffassign) ipv4, err = types.ParseCIDR("10.0.0.2/24") ^ Signed-off-by: Sebastiaan van Stijn <[email protected]>Configuration menu - View commit details
-
Copy full SHA for 7af6620 - Browse repository at this point
Copy the full SHA 7af6620View commit details -
golint: add "nolint" for cni.CNIOpt and cni.CNIResult
We should consider renaming, but may have to keep the old name as alias, given that this module already is at v1.x.x, so we cannot introduce breaking changes. opts.go:27:6: type name will be used as cni.CNIOpt by other packages, and that stutters; consider calling this Opt (golint) type CNIOpt func(c *libcni) error ^ result.go:32:6: type name will be used as cni.CNIResult by other packages, and that stutters; consider calling this Result (golint) type CNIResult struct { ^ Signed-off-by: Sebastiaan van Stijn <[email protected]>Configuration menu - View commit details
-
Copy full SHA for 2285fea - Browse repository at this point
Copy the full SHA 2285feaView commit details -
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 34348e7 - Browse repository at this point
Copy the full SHA 34348e7View commit details -
Temporarily disable EXC0002 until GoDoc is fixed in this repo
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 30d0272 - Browse repository at this point
Copy the full SHA 30d0272View commit details -
This project is used as a library and doesn't produce binaries, in which case convention is to not use vendoring. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7065daf - Browse repository at this point
Copy the full SHA 7065dafView commit details
Commits on Mar 17, 2021
-
Merge pull request #64 from thaJeztah/remove_vendor_and_update_cni
Remove vendor directory
Configuration menu - View commit details
-
Copy full SHA for b83843b - Browse repository at this point
Copy the full SHA b83843bView commit details
Commits on Mar 18, 2021
-
Merge pull request #63 from thaJeztah/move_gha
Move CI to use GitHub Actions
Configuration menu - View commit details
-
Copy full SHA for c77d4f1 - Browse repository at this point
Copy the full SHA c77d4f1View commit details -
Rename/deprecate CNIOpt and CNIResult (golint)
To address golint; opts.go:27:6: type name will be used as cni.CNIOpt by other packages, and that stutters; consider calling this Opt (golint) type CNIOpt func(c *libcni) error ^ result.go:32:6: type name will be used as cni.CNIResult by other packages, and that stutters; consider calling this Result (golint) type CNIResult struct { ^ The old names are kept for backward compatiblity (as this module is already past v1.0.0) Signed-off-by: Sebastiaan van Stijn <[email protected]>Configuration menu - View commit details
-
Copy full SHA for ce60981 - Browse repository at this point
Copy the full SHA ce60981View commit details -
Deprecate CNI.GetCNIResultFromResults()
This function looks to be used internally only in CNI.Setup(), so mark it deprecated to discourage using it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6835ef2 - Browse repository at this point
Copy the full SHA 6835ef2View commit details -
Project has switched to GitHub actions, so we can now remove this Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f8a5662 - Browse repository at this point
Copy the full SHA f8a5662View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8a934a - Browse repository at this point
Copy the full SHA a8a934aView commit details -
Merge pull request #65 from thaJeztah/rename_types
Rename/deprecate CNIOpt, CNIResult, CNI.GetCNIResultFromResults
Configuration menu - View commit details
-
Copy full SHA for b5e1823 - Browse repository at this point
Copy the full SHA b5e1823View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.1...v1.0.2