Skip to content

Update Go vers, x/sys vendor#51

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
estesp:update-xsys
Feb 17, 2023
Merged

Update Go vers, x/sys vendor#51
dmcgowan merged 1 commit intocontainerd:mainfrom
estesp:update-xsys

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Feb 17, 2023

Update linter version and align linter settings with main containerd project.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread go.mod Outdated
@@ -4,7 +4,7 @@ go 1.18

require (
github.com/stretchr/testify v1.8.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not urgent, but I saw there was a v1.8.1 as well

@thaJeztah
Copy link
Copy Markdown
Member

Ah; linter complains;

prefix=src/github.com/containerd/fifo] in [/Users/runner/work/fifo/fifo/src/github.com/containerd/fifo] ...
  Error: directive `//nolint: unconvert` is unused for linter "unconvert" (nolintlint)
  
  Error: issues found

Update linter version and align linter settings with main containerd
project.

Signed-off-by: Phil Estes <[email protected]>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 151b205 into containerd:main Feb 17, 2023
@estesp estesp deleted the update-xsys branch February 20, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants