Fix linting, remove solaris code, and exclude files on Windows#39
Merged
estesp merged 4 commits intocontainerd:masterfrom Mar 30, 2021
Merged
Conversation
This reverts commit 14d8313. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This caused builds on Windows to fail, and no work is done on Solaris builds,
so we might as wel remove this code
typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\mkfifo_nosolaris.go:24:17: Mkfifo not declared by package syscall
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Previous attempts to exclude more granular failed, so excluding most/all files on windows
typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\handle_nolinux.go:34:19: Stat_t not declared by package syscall
typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\handle_nolinux.go:35:20: Stat not declared by package syscall
typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\raw_test.go:220:27: cannot use int(fd) (value of type int) as syscall.Handle value in argument to syscall.Write
typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\raw_test.go:240:26: cannot use int(fd) (value of type int) as syscall.Handle value in argument to syscall.Read
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
thaJeztah
force-pushed
the
remove_solaris_fix_windows
branch
from
c1bbb73 to
d7380cc
Compare
Member
Author
|
Tested these changes in containerd/containerd#5269 to verify all is working |
thaJeztah
requested review from
AkihiroSuda and
cpuguy83
and removed request for
AkihiroSuda
Member
Author
AkihiroSuda
approved these changes
Mar 29, 2021
mxpv
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts 14d8313 (#36), as there were many other paths that failed to compile on Windows, so it was a wasted effort.
Also;
Unfortunately, linting still fails on windows; see #38 (comment) for unknown reasons, so I think I'll call it a day (no windows code should import this)