run linters on macOS and Windows as well#38
Merged
mxpv merged 1 commit intocontainerd:masterfrom Mar 31, 2021
Merged
Conversation
Member
Author
|
This will fail currently (until #36 is merged; will rebase after to verify it fixes that in CI) |
70c79cb to
fcb04e2
Compare
Member
Author
|
Arg... more compile errors on Windows; |
d5bee1f to
f6abba5
Compare
Member
Author
|
golangci-lint.. I hate you.. this is absolutely useless; somewhere, some place a file is detected as "not gofmt'ed".. so.. where???? |
5337989 to
f611d3f
Compare
Member
|
This might be because of line endings. |
Member
Author
|
Oh! Thanks! Let me give that a try |
23fff05 to
a178792
Compare
Member
Author
|
That was it! You're a hero! It's green now (with #39 included, so still as "draft") |
Mostly to catch if we correctly specified build-tags Signed-off-by: Sebastiaan van Stijn <[email protected]>
a178792 to
a0bdb4a
Compare
Member
Author
mxpv
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly to catch if we correctly specified build-tags (see #36)