Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containerd/fifo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 115abcc
Choose a base ref
...
head repository: containerd/fifo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 650e8a8
Choose a head ref
  • 11 commits
  • 11 files changed
  • 4 contributors

Commits on Mar 23, 2021

  1. exclude OpenFifoDup2() on Windows

    Commit 9c214ed updated this function, and
    replaced syscall.Dup2() for golang.org/x/sys/unix.Dup2(), which is not
    available on Windows.
    
    This patch splits the API from the implementation, and moves the unix
    implementation to a "unix" file; a stub is added for Windows.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    14d8313 View commit details
    Browse the repository at this point in the history
  2. Add IsFifo() utility

    This copies the github.com/containerd/containerd/sys.IsFifo() utility,
    which is used in tandem with other functionality from this module, so
    I thought it made sense to combine them here.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    a0b2081 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Merge pull request #36 from thaJeztah/fix_non_unix

    exclude OpenFifoDup2() on Windows
    dmcgowan authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    8814b01 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #37 from thaJeztah/add_isfifo_util

    Add IsFifo() utility
    dmcgowan authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    4614834 View commit details
    Browse the repository at this point in the history
  3. Revert "exclude OpenFifoDup2() on Windows"

    This reverts commit 14d8313.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    847f54e View commit details
    Browse the repository at this point in the history
  4. fix: goimports and unconvert

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    5be08d2 View commit details
    Browse the repository at this point in the history
  5. mkfifo: remove solaris code

    This caused builds on Windows to fail, and no work is done on Solaris builds,
    so we might as wel remove this code
    
        typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\mkfifo_nosolaris.go:24:17: Mkfifo not declared by package syscall
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    df04ad1 View commit details
    Browse the repository at this point in the history
  6. exclude on Windows, and remove go1.12 build-tag

    Previous attempts to exclude more granular failed, so excluding most/all files on windows
    
        typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\handle_nolinux.go:34:19: Stat_t not declared by package syscall
        typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\handle_nolinux.go:35:20: Stat not declared by package syscall
        typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\raw_test.go:220:27: cannot use int(fd) (value of type int) as syscall.Handle value in argument to syscall.Write
        typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\raw_test.go:240:26: cannot use int(fd) (value of type int) as syscall.Handle value in argument to syscall.Read
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    d7380cc View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Merge pull request #39 from thaJeztah/remove_solaris_fix_windows

    Fix linting, remove solaris code, and exclude files on Windows
    estesp authored Mar 30, 2021
    Configuration menu
    Copy the full SHA
    a77444a View commit details
    Browse the repository at this point in the history
  2. run linters on macOS and Windows as well

    Mostly to catch if we correctly specified build-tags
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    a0bdb4a View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Configuration menu
    Copy the full SHA
    650e8a8 View commit details
    Browse the repository at this point in the history
Loading