-
Notifications
You must be signed in to change notification settings - Fork 30
Comparing changes
Open a pull request
base repository: containerd/fifo
base: 115abcc
head repository: containerd/fifo
compare: 650e8a8
- 11 commits
- 11 files changed
- 4 contributors
Commits on Mar 23, 2021
-
exclude OpenFifoDup2() on Windows
Commit 9c214ed updated this function, and replaced syscall.Dup2() for golang.org/x/sys/unix.Dup2(), which is not available on Windows. This patch splits the API from the implementation, and moves the unix implementation to a "unix" file; a stub is added for Windows. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 14d8313 - Browse repository at this point
Copy the full SHA 14d8313View commit details -
This copies the github.com/containerd/containerd/sys.IsFifo() utility, which is used in tandem with other functionality from this module, so I thought it made sense to combine them here. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0b2081 - Browse repository at this point
Copy the full SHA a0b2081View commit details
Commits on Mar 25, 2021
-
Merge pull request #36 from thaJeztah/fix_non_unix
exclude OpenFifoDup2() on Windows
Configuration menu - View commit details
-
Copy full SHA for 8814b01 - Browse repository at this point
Copy the full SHA 8814b01View commit details -
Merge pull request #37 from thaJeztah/add_isfifo_util
Add IsFifo() utility
Configuration menu - View commit details
-
Copy full SHA for 4614834 - Browse repository at this point
Copy the full SHA 4614834View commit details -
Revert "exclude OpenFifoDup2() on Windows"
This reverts commit 14d8313. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 847f54e - Browse repository at this point
Copy the full SHA 847f54eView commit details -
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5be08d2 - Browse repository at this point
Copy the full SHA 5be08d2View commit details -
This caused builds on Windows to fail, and no work is done on Solaris builds, so we might as wel remove this code typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\mkfifo_nosolaris.go:24:17: Mkfifo not declared by package syscall Signed-off-by: Sebastiaan van Stijn <[email protected]>Configuration menu - View commit details
-
Copy full SHA for df04ad1 - Browse repository at this point
Copy the full SHA df04ad1View commit details -
exclude on Windows, and remove go1.12 build-tag
Previous attempts to exclude more granular failed, so excluding most/all files on windows typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\handle_nolinux.go:34:19: Stat_t not declared by package syscall typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\handle_nolinux.go:35:20: Stat not declared by package syscall typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\raw_test.go:220:27: cannot use int(fd) (value of type int) as syscall.Handle value in argument to syscall.Write typechecking error: D:\\a\\fifo\\fifo\\src\\github.com\\containerd\\fifo\\raw_test.go:240:26: cannot use int(fd) (value of type int) as syscall.Handle value in argument to syscall.Read Signed-off-by: Sebastiaan van Stijn <[email protected]>Configuration menu - View commit details
-
Copy full SHA for d7380cc - Browse repository at this point
Copy the full SHA d7380ccView commit details
Commits on Mar 30, 2021
-
Merge pull request #39 from thaJeztah/remove_solaris_fix_windows
Fix linting, remove solaris code, and exclude files on Windows
Configuration menu - View commit details
-
Copy full SHA for a77444a - Browse repository at this point
Copy the full SHA a77444aView commit details -
run linters on macOS and Windows as well
Mostly to catch if we correctly specified build-tags Signed-off-by: Sebastiaan van Stijn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0bdb4a - Browse repository at this point
Copy the full SHA a0bdb4aView commit details
Commits on Mar 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 650e8a8 - Browse repository at this point
Copy the full SHA 650e8a8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 115abcc...650e8a8