Add a resolve error function to return first error#9
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Jun 21, 2024
Merged
Add a resolve error function to return first error#9dmcgowan merged 1 commit intocontainerd:mainfrom
dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
estesp
approved these changes
Jun 21, 2024
henry118
reviewed
Jun 21, 2024
henry118
approved these changes
Jun 21, 2024
When an error object is returned and must be resolved to a single return error, the first error matching one defined by this package should be returned. Signed-off-by: Derek McGowan <[email protected]>
Member
Author
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an error object is returned and must be resolved to a single return error, the first error matching one defined by this package should be returned.
This is needed to accurately resolve a grpc when an error is wrapped. For example if wrapping a
NotFounderror withErrInvalidArgument, thenErrInvalidArgumentshould be used to resolve the status code. The ordering of the error chain should have precedence over the ordering of theIs*checks.