Merged
Conversation
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
fab7827 to
05e7f12
Compare
estesp
approved these changes
Jun 20, 2024
Signed-off-by: Derek McGowan <[email protected]>
05e7f12 to
f96dfda
Compare
stevvooe
approved these changes
Jun 21, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new stack package which provides a stack error type. This is based off the stack from the archived
pkg/errorspackage and buildkit'sutil/stack.Differences...
Unwrap() []errorinterface. This allows stacks to ride next to errors without changing their error structure. Introduced a "collapsible" interface to avoid outputting the stack errors unless the%+voption is given.runtime.CallerFramesto account for inlined functions instead of the "discourage"runtime.FuncForPC. See https://pkg.go.dev/runtime#Callers