Merged
Conversation
Member
|
Very supportive of this split. thanks @dmcgowan |
AkihiroSuda
approved these changes
Oct 1, 2024
cpuguy83
requested changes
Oct 2, 2024
pkg/go.mod
Outdated
| @@ -0,0 +1,16 @@ | |||
| module github.com/containerd/errdefs/pkg | |||
|
|
|||
| go 1.23.1 | |||
Member
There was a problem hiding this comment.
Can this be max go1.22?
The other go.mod is 1.20.
Separate the error definitions from the packages which use them. Signed-off-by: Derek McGowan <[email protected]>
cpuguy83
approved these changes
Oct 2, 2024
samuelkarp
reviewed
Oct 2, 2024
| go 1.22 | ||
|
|
||
| require ( | ||
| github.com/containerd/errdefs v0.2.0 |
Member
There was a problem hiding this comment.
I assume then we need to update this once we tag a new version?
Member
Author
There was a problem hiding this comment.
Yeah, we should update once we have the split version for sure
samuelkarp
approved these changes
Oct 7, 2024
Merged
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the error definitions from the packages which use them.
This will allow us to keep our error definitions in a 1.0 package that shouldn't ever need a 2.0 since we are basing the errors on a fixed set.
The libraries which create and manipulate the errors are likely to change and possibly need major version bumps. If the error definitions are in the same go module, this makes the error types incompatible through type checking and requires use of the interfaces. While the interfaces may be better for version compatibility,
errors.Isis the most idiomatic solution.