This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Fix ip leakage #949
Merged
Fix ip leakage #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Random-Liu
force-pushed
the
fix-ip-leakage
branch
from
f841d58 to
63abcbb
Compare
Random-Liu
force-pushed
the
fix-ip-leakage
branch
from
63abcbb to
bfbff99
Compare
mikebrow
reviewed
Oct 10, 2018
integration/test_utils.go
Outdated
| @@ -295,6 +298,15 @@ func KillProcess(name string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // KillPid kills the process by pid. kill is used. | |||
| func KillPid(pid int) error { | |||
| output, err := exec.Command("kill", "-9", strconv.Itoa(pid)).CombinedOutput() | |||
There was a problem hiding this comment.
i think you wanted to send a SIGTERM here (-15) not a SIGKILL? or maybe the KillProcess is wrong as I see it's using default which I believe is SIGTERM.
There was a problem hiding this comment.
Use kill directly, which uses SIGTERM by default.
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
fix-ip-leakage
branch
2 times, most recently
from
8fa56d0 to
79ae65e
Compare
Signed-off-by: Lantao Liu <[email protected]>
Done. |
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
fix-ip-leakage
branch
from
79ae65e to
84775d2
Compare
Random-Liu
added a commit
that referenced
this pull request
Oct 12, 2018
Cherrypick #949 release 1.2
Random-Liu
added a commit
that referenced
this pull request
Oct 21, 2018
Cherrypick #949 release 1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948.
Based on containerd/go-cni#31.
We should cherrypick this PR into all supported branches.