Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Conversation

@Random-Liu
Copy link
Member

We should unpack image during import, so that the lease can help us hold the resource.

Similar issue with containerd/containerd#2331.

Signed-off-by: Lantao Liu [email protected]

@Random-Liu Random-Liu force-pushed the unpack-during-import branch from 02705e6 to e1a37e8 Compare July 26, 2018 07:48
@Random-Liu
Copy link
Member Author

This PR also disables gsec, because gas is renamed to gsec. alecthomas/gometalinter#505

@Random-Liu Random-Liu mentioned this pull request Jul 26, 2018
--disable=aligncheck \
--disable=gotype \
--disable=gas \
--disable=gosec \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's why ci broke :-)

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Random-Liu Random-Liu merged commit 1263024 into containerd:master Jul 26, 2018
@Random-Liu Random-Liu deleted the unpack-during-import branch July 26, 2018 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants