This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Doc (registry): Update to the image registry doc#1591
Merged
mikebrow merged 2 commits intocontainerd:masterfrom Oct 1, 2020
Merged
Doc (registry): Update to the image registry doc#1591mikebrow merged 2 commits intocontainerd:masterfrom
mikebrow merged 2 commits intocontainerd:masterfrom
Conversation
|
Hi @hickeyma. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hickeyma
force-pushed
the
impr-img-reg-doc
branch
2 times, most recently
from
60182e4 to
9caa12d
Compare
Signed-off-by: Martin Hickey <[email protected]>
hickeyma
force-pushed
the
impr-img-reg-doc
branch
from
9caa12d to
70a56ae
Compare
hickeyma
changed the title
hickeyma
changed the title
mikebrow
reviewed
Sep 30, 2020
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
looking good just a couple nits
Review comments: - containerd#1591 (review) Signed-off-by: Martin Hickey <[email protected]>
Contributor
Author
|
Thanks for the review @mikebrow. Updated and ready for review again. |
shahzzzam
pushed a commit
to shahzzzam/cri
that referenced
this pull request
Oct 3, 2020
Signed-off-by: Samarth Shah <[email protected]> update description Signed-off-by: Samarth Shah <[email protected]> only decorate MediaTypeDockerSchema2Manifest Signed-off-by: Samarth Shah <[email protected]> allocate Annotations if nil Signed-off-by: Samarth Shah <[email protected]> update config syntax in registry.md Signed-off-by: Yecheng Fu <[email protected]> Set masked and readonly paths based on default Unix spec The default values of masked and readonly paths are defined in populateDefaultUnixSpec, and are used when a sandbox is created. It is not, however, used for new containers. If a container definition does not contain a security context specifying masked/readonly paths, a container created from it does not have masked and readonly paths. This patch applies the default values to masked and readonly paths of a new container, when any specific values are not specified. Fixes containerd#1569 Signed-off-by: Yohei Ueda <[email protected]> Update to latest kubernetes v1.19.2 Signed-off-by: Davanum Srinivas <[email protected]> vendor: containerd/containerd v1.4.1 Signed-off-by: Sebastiaan van Stijn <[email protected]> pkg/server: make ensureRemoveAll() an alias for os.RemoveAll() on Windows The tricks performed by ensureRemoveAll only make sense for Linux and other Unices, so separate it out, and make ensureRemoveAll for Windows just an alias of os.RemoveAll. Signed-off-by: Sebastiaan van Stijn <[email protected]> Update after review Review comments: - containerd#1591 (review) Signed-off-by: Martin Hickey <[email protected]> Use tabs in protofile indentation This is enforced as part of containerd's fmt checks Signed-off-by: Derek McGowan <[email protected]> Align lint checks with containerd Signed-off-by: Derek McGowan <[email protected]> Enable golangci on Windows Signed-off-by: Derek McGowan <[email protected]> move annotation to children Signed-off-by: Samarth Shah <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the "Configure image registry" doc, I noticed some improvements which could help users. This PR adds these improvements.