Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

fix no-pivot not working in io.containerd.runtime.v1.linux#1582

Closed
Zhang-Jianming wants to merge 1 commit intocontainerd:masterfrom
Zhang-Jianming:no-pivot-not-working
Closed

fix no-pivot not working in io.containerd.runtime.v1.linux#1582
Zhang-Jianming wants to merge 1 commit intocontainerd:masterfrom
Zhang-Jianming:no-pivot-not-working

Conversation

@Zhang-Jianming
Copy link
Copy Markdown

@Zhang-Jianming Zhang-Jianming commented Sep 21, 2020 •
edited
Loading

no_pivot not working in io.containerd.runtime.v1.linux

relates to 1220

Signed-off-by: zhangjianming [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 21, 2020

Hi @Zhang-Jianming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Zhang-Jianming
Copy link
Copy Markdown
Author

Zhang-Jianming commented Sep 26, 2020

@mikebrow @Random-Liu PTAL. Thanks

mikebrow
mikebrow approved these changes Sep 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
See nit for additional comment

Comment thread pkg/server/sandbox_run_unix.go
@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Sep 29, 2020

/ok-to-test

@Zhang-Jianming
Copy link
Copy Markdown
Author

Zhang-Jianming commented Oct 10, 2020

/retest

AkihiroSuda
AkihiroSuda suggested changes Oct 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but the code was recently moved to the main containerd repo: https://github.com/containerd/containerd/tree/master/pkg/cri

Please reopen in the new repo, sorry for inconvenience

@AkihiroSuda AkihiroSuda marked this pull request as draft October 10, 2020 16:09
@Zhang-Jianming Zhang-Jianming mentioned this pull request Oct 12, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mikebrow mikebrow Awaiting requested review from mikebrow

1 more reviewer

@AkihiroSuda AkihiroSuda AkihiroSuda requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zhang-Jianming @k8s-ci-robot @mikebrow @AkihiroSuda