Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Fix proc mount support.#1209

Merged
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-proc-mount-support
Aug 1, 2019
Merged

Fix proc mount support.#1209
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-proc-mount-support

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Jul 26, 2019

For #1208.

Note that a disable_proc_mount option has to be introduced to support Kubernetes 1.11.

Given that 1) containerd 1.1 will go into security patch only mode soon; 2) 1.3 is still WIP; 3) many production Kubernetes clusters are still on 1.11; I think not supporting 1.11 is not an option.

@choury

Signed-off-by: Lantao Liu [email protected]

@Random-Liu Random-Liu added this to the v1.2 milestone Jul 26, 2019
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Signed-off-by: Lantao Liu <[email protected]>
@Random-Liu Random-Liu force-pushed the fix-proc-mount-support branch from 88c7dd8 to 467f9e0 Compare August 1, 2019 00:11
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 1, 2019
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu Random-Liu merged commit fe5eb76 into containerd:master Aug 1, 2019
@Random-Liu Random-Liu deleted the fix-proc-mount-support branch August 1, 2019 06:23
Random-Liu added a commit that referenced this pull request Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants