Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Do not cache image handler.#1202

Merged
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:not-cache-image-handler
Jul 25, 2019
Merged

Do not cache image handler.#1202
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:not-cache-image-handler

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Jul 24, 2019

/cc @sofat1989

Fixes containerd/containerd#3401.

Signed-off-by: Lantao Liu [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 24, 2019

@Random-Liu: GitHub didn't allow me to request PR reviews from the following users: sofat1989.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @sofat1989

Fixes containerd/containerd#3401.

Signed-off-by: Lantao Liu [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Jul 24, 2019

the change looks good... need to figure out the test failure though.

@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Jul 24, 2019

There is some problem with this approach. Let me think about it a little bit.

@Random-Liu Random-Liu force-pushed the not-cache-image-handler branch from eba2808 to fe0cb22 Compare July 24, 2019 22:38
@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Jul 24, 2019

@mikebrow Fixed. The problem is that when ImageStatus returns an image, the image ID reference in containerd may not be ready yet.

I changed the PR to get an actual reference from the reference list, which ensures that the reference should exist in containerd.

@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Jul 24, 2019

We should cherry-pick this to 1.2 to fix containerd/containerd#3401

@Random-Liu Random-Liu added this to the v1.2 milestone Jul 24, 2019
@Random-Liu Random-Liu mentioned this pull request Jul 24, 2019
Closed
mikebrow
mikebrow approved these changes Jul 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

jterry75
jterry75 approved these changes Jul 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu Random-Liu merged commit 240e19d into containerd:master Jul 25, 2019
@Random-Liu Random-Liu deleted the not-cache-image-handler branch July 25, 2019 18:57
@Random-Liu Random-Liu mentioned this pull request Jul 26, 2019
Merged
Random-Liu added a commit that referenced this pull request Jul 29, 2019
@Random-Liu
Merge pull request #1210 from Random-Liu/cherrypick-1202-release-1.2
106dfbd 
Cherrypick #1202 release/1.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jterry75 jterry75 jterry75 approved these changes

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikebrow mikebrow

Labels

cherrypick-needed cherrypicked lgtm size/S

Projects

None yet

Milestone

v1.2

Development

Successfully merging this pull request may close these issues.

failed to create containerd container: error unpacking image: content digest sha256:16*: not found"

4 participants

@Random-Liu @k8s-ci-robot @mikebrow @jterry75