Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

[release/1.2 backport] Fix runc and critools version in release.#1193

Merged
mikebrow merged 1 commit intocontainerd:release/1.2from
thaJeztah:1.2_backport_fix_version
Jul 16, 2019
Merged

[release/1.2 backport] Fix runc and critools version in release.#1193
mikebrow merged 1 commit intocontainerd:release/1.2from
thaJeztah:1.2_backport_fix_version

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jun 26, 2019

Noticed that this one was labeled for backporting but no backport yet;

cherry-pick of #1180 for the 1.2 branch

(cherry picked from commit 6afd137)

@Random-Liu @thaJeztah
Fix runc and critools version in release.
0c86149 
Signed-off-by: Lantao Liu <[email protected]>
(cherry picked from commit 6afd137)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 26, 2019

Hi @thaJeztah. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Jun 26, 2019

/ok-to-test

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 26, 2019

/test pull-cri-containerd-node-e2e

mikebrow
mikebrow approved these changes Jun 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mikebrow mikebrow merged commit f68a182 into containerd:release/1.2 Jul 16, 2019
@thaJeztah thaJeztah deleted the 1.2_backport_fix_version branch July 16, 2019 21:50
@Random-Liu Random-Liu mentioned this pull request Aug 15, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikebrow mikebrow

Labels

lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @k8s-ci-robot @mikebrow @Random-Liu