Fix runc and critools version in release.#1180
Conversation
Signed-off-by: Lantao Liu <[email protected]>
|
Will it be confusing to give runc a new version, given that they also tag versions upstream? |
|
@thaJeztah it is not a new version it is the version we have selected to pull and build from the git their repos eg: https://github.com/containerd/cri/blob/master/vendor.conf#L37 I believe what he meant above is we were previously failing to pass in the version we selected to the make builds and thus possibly using the wrong version tag in those builds. (The containerd version vs the one we have chosen in containerd/cri.) We have a who's on first cyclic versioning issue between containerd/containerd and containerd/cri that may affect workflow. |
|
at some point we probably need to stop building release binaries this way... I completely forgot we were still packaging up runc and crictl in a cri package. |
|
Oh! Must have misunderstood, thought this would version all of them the same as the containerd version (thus "runc v1.2.7" if that's the version of containerd) |
Without the fix, it would version all of them as the containerd version. |
Runc and critools are both versioned with containerd version, e.g. 1.2.6, without the fix.
Signed-off-by: Lantao Liu [email protected]