Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Fix runc and critools version in release.#1180

Merged
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-version
Jun 21, 2019
Merged

Fix runc and critools version in release.#1180
Random-Liu merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-version

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

Runc and critools are both versioned with containerd version, e.g. 1.2.6, without the fix.
Signed-off-by: Lantao Liu [email protected]

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@thaJeztah
Copy link
Copy Markdown
Member

Will it be confusing to give runc a new version, given that they also tag versions upstream?

@mikebrow
Copy link
Copy Markdown
Member

@thaJeztah it is not a new version it is the version we have selected to pull and build from the git their repos eg: https://github.com/containerd/cri/blob/master/vendor.conf#L37

I believe what he meant above is we were previously failing to pass in the version we selected to the make builds and thus possibly using the wrong version tag in those builds. (The containerd version vs the one we have chosen in containerd/cri.) We have a who's on first cyclic versioning issue between containerd/containerd and containerd/cri that may affect workflow.

@mikebrow
Copy link
Copy Markdown
Member

at some point we probably need to stop building release binaries this way... I completely forgot we were still packaging up runc and crictl in a cri package.

@thaJeztah
Copy link
Copy Markdown
Member

Oh! Must have misunderstood, thought this would version all of them the same as the containerd version (thus "runc v1.2.7" if that's the version of containerd)

@Random-Liu
Copy link
Copy Markdown
Member Author

Oh! Must have misunderstood, thought this would version all of them the same as the containerd version (thus "runc v1.2.7" if that's the version of containerd)

Without the fix, it would version all of them as the containerd version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants